[Bug 712971] Review Request: gnome-shell-extension-pidgin - The components necessary to integrate Pidgin with GNOME Shell

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=712971

--- Comment #3 from Tim Lauridsen <tla at rasmil.dk> 2011-06-15 08:02:28 EDT ---
Issues:
[!] : MUST - Rpmlint output is silent.

        rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm
       
================================================================================
        gnome-shell-extension-pidgin.i686: W: no-documentation
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.
       
================================================================================

        rpmlint
gnome-shell-extension-pidgin-debuginfo-0-0.1.git4ca78b1.fc16.i686.rpm
       
================================================================================
        gnome-shell-extension-pidgin-debuginfo.i686: E:
description-line-too-long C This package provides debug information for package
gnome-shell-extension-pidgin.
        1 packages and 0 specfiles checked; 1 errors, 0 warnings.
       
================================================================================

        rpmlint gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.src.rpm
       
================================================================================
        gnome-shell-extension-pidgin.src: W: invalid-url Source0:
gnome-shell-extension-pidgin-git4ca78b1.tar.bz2
        1 packages and 0 specfiles checked; 0 errors, 1 warnings.
       
================================================================================

[!] : MUST - Development .so files in -devel subpackage, if present.
        gnome-shell-extension-pidgin-0-0.1.git4ca78b1.fc16.i686.rpm :
/usr/lib/purple-2/libgnomeshell.so

Looks ok, this is a plugin not at development lib.

[!] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        Makefile.gnomeShellPidgin :
          MD5SUM this package     : 52fd5b3e0fe1afe78c0119408a17d2fe
          MD5SUM upstream package : upstream source not found
        gnome-shell-extensions-pidgin-License.txt :
          MD5SUM this package     : d3ea637572fb8f52b510a60876c6f218
          MD5SUM upstream package : upstream source not found
        gnome-shell-extension-pidgin-git4ca78b1.tar.bz2 :
          MD5SUM this package     : 2267235a4e7efdd73a2557b107cd9e64
          MD5SUM upstream package : upstream source not found
        /home/tim/tmp/reviewhelper/712971/gnomeShellPidgin.c :
          MD5SUM this package     : 09c4edcd6a1ce1c7008d942862cf7562
          MD5SUM upstream package : 09c4edcd6a1ce1c7008d942862cf7562

 Should be OK, this is a git checkout and the other files is license and a
Makefile to get it build


[!] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.

Little unsure if the Source3 license file should be installed and put into %DOC
?

Let me know what you think about the Source3 issue and I will approve it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.