[Bug 691115] Review Request: python-kombu - AMQP Messaging Framework for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=691115

--- Comment #6 from Lakshmi Narasimhan <lakshminaras2002 at gmail.com> 2011-06-25 13:31:12 EDT ---
Hi Fabian, there are some rpmlint issues that need fixing.

>>python-kombu.noarch: W: incoherent-version-in-changelog 1.1.3.1 ['1.1.3-1.fc15', '1.1.3-1']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

1)  Needs fixing

python-kombu.noarch: W: hidden-file-or-dir
/usr/share/doc/python-kombu-1.1.3/docs/.static/.keep
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

python-kombu.noarch: E: zero-length
/usr/share/doc/python-kombu-1.1.3/docs/.static/.keep
python-kombu.noarch: W: hidden-file-or-dir
/usr/share/doc/python-kombu-1.1.3/docs/.static
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

python-kombu.noarch: W: hidden-file-or-dir
/usr/share/doc/python-kombu-1.1.3/docs/.static
The file or directory is hidden. You should see if this is normal, and delete
it from the package if not.

2) I noticed that the docs folder has files which cannot be viewed in a
browser. It also has a makefile. It turns out that the makefile can be used to
generate html files. I have attached a modified spec file that does that.
Although we don't have all the dependent modules in the repo to generate the
docs, the makefile seems to be ok with that. I checked the generated docs and
it seems to be usable.

3) For generating the docs, python-couchdb is needed (and could be used at
runtime as well). However the tests fail if python-couchdb is installed. It
seems that a required class definition is not available for python v > 2.7.
This would definitely cause an issue at runtime. Could you contact upstream and
ask for a fix.

Attaching the modified spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.