[Bug 680205] Review Request: allegro5 - Allegro 5 is a game programming library.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=680205

Hans de Goede <hdegoede at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Hans de Goede <hdegoede at redhat.com> 2011-03-11 15:03:26 EST ---
Hi,

(In reply to comment #10)
> The only thing
> that bothers me now is the "W: unused-direct-shlib-dependency" warnings when
> tested against the installed packages.

Oh, good one I did not do that (run rpmlint on the installed package), I just
did this and I saw these too. Looking closer at them they are harmless. 

I've taken another look at your package and it looks fine now!

One remaining issue is that rpmlint now says:
allegro5.src:294: W: macro-in-%changelog %doc
allegro5.src:299: W: macro-in-%changelog %exclude

You can fix this by using %%doc / %%exclude in the changelog in the spec file,
which will then expand to %doc / %exclude in the changelog in the actual build
rpms. I don't see this as a blocker / a reason to do another release. Please do
fix this before importing the package into fedora pkg git (step 2.1.17 of:
http://fedoraproject.org/wiki/PackageMaintainers/Join).

This package is APPROVED!

Please go create an account in the Fedora Account System if you've not done so
already, and let me now your fas login and then I'll sponsor you.

Regards,

Hans



p.s.

Can you please provide karma to the following updates (after logging in first,
create a Fedora Account System account for this if you haven't already):
https://admin.fedoraproject.org/updates/dumb-0.9.3-11.fc14
https://admin.fedoraproject.org/updates/dumb-0.9.3-11.fc15

If you provide karma they will go to updates stable, so that the correct
version of dump will be in place when you build allegro5 for F-15 / F-14. Do
you plan on also building it for F-13 ? (then I need to do a dumb update for
that too).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.