[Bug 674188] Review Request: libzeitgeist - Library to access zeitgeist; needed by synapse

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674188

--- Comment #21 from Renich Bon Ciric <renich at woralelandia.com> 2011-03-22 02:20:59 EDT ---
(In reply to comment #20)

Im sorry; here they are:
spec: http://renich.fedorapeople.org/SPECS/libzeitgeist.spec
srpm: http://renich.fedorapeople.org/SRPMS/libzeitgeist-0.3.6.1.fc14.src.rpm


> For -3:
> * %{?_isa} specific dependency
>   - As said in the comment 14, -devel subpackage should have
>     "%{name}%{?_isa} = %{version}-%{release}"

Ok, changed it on the summary and requires too.

>   - And it is very likely that "Requires: zeitgeist" should be
>     %{_isa} specific.

I think not; since zeitgeist is .noarch ;)

> * %check
>   - So please fix %check failure or rescue it so that rpmbuild
>     on koji succeeds.

Working on this at the time of writing. I will disable the test as soon as I
figure out how. 

No idea of why it builds with rpmbuild and not in mock/koji... some missing dep
perhaps? been checking configure.ac but... I dunno... still on it... 

> * %doc attribute
>   - As said in the comment 16, "%doc" attribute on 
>     %{_datadir}/gtk-doc/html/foo is not needed.

Woops... sorry... finally understood ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.