[Bug 754554] Review Request: presence - Bi-directional audio/video connections

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=754554

--- Comment #11 from Fabian Deutsch <fabian.deutsch at gmx.de> 2011-11-18 07:04:04 EST ---
(In reply to comment #10)

> Issues:
> [!]: MUST Package run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) and the
> beginning of %install. (EPEL5)

Fixed.

>  - just in case you want EPEL5 branch, then you'd need defattr back as well and
> buildroot def. I guess not...

I am not yet interested in getting this into EPEL :)

> [!]: MUST Package must own all directories that it creates.
>   /usr/share/presence is unowned

I suppose this was because of globbing, I added the dir explicitly.

> [!]: SHOULD Package functions as described.
> 
> While I don't have a webcam in my pc, I'd assume the application shows icons in
> bottom screen area. Those buttons work, but they have no icons so it's
> impossible to navigate. Perhaps some missing requires?

Yes, I suppose you ain't running GNOME? :) I added a dependency on
gnome-icon-theme and -symbolic this should solve this.
And you'll need to be creative to test the software on a machine without a
webcam :)

specfile:
https://gitorious.org/valastuff/presence/blobs/spec/presence.spec

srpm:
http://fabiand.fedorapeople.org/presence/presence-0.4.4-2.fc16.src.rpm

koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3523562

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.