[Bug 754436] Review Request: libvirt-glib - libvirt glib integration for event
bugzilla at redhat.com
bugzilla at redhat.com
Mon Nov 21 19:54:41 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=754436
--- Comment #2 from Matthias Clasen <mclasen at redhat.com> 2011-11-21 14:54:41 EST ---
Quick preliminary review of the spec file:
I guess you are aiming for building on old releases as well, which explains why
you have rm -rf $RPM_BUILD_ROOT in %install and a %clean section. In F16/F17,
these are no longer needed.
ldconfig in %post/%postun is indeed missing
Is the 2008 date in %changelog a typo ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list