[Bug 740160] Review Request: discount - An implementation of the Markdown language in C

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=740160

--- Comment #9 from Craig Barnes <cbgnome at gmail.com> 2011-10-01 01:32:57 EDT ---
(In reply to comment #8)
> > I did this and rpmlint gave an error (E: explicit-lib-dependency). I researched it a little and it seems that if the base package depends on a sub-package library, RPM handles the dependency automatically. Correct me if I'm wrong. I have left this one out for now.
> 
> Are you sure? I just tried adding "Requires: libmarkdown%{?_isa} =
> %{version}-%{release}" below the BuildRequires and I don't get any rpmlint
> errors. (I can also think of two existing packages that do this: curl and
> ufraw).

Yeah, you're right. I just added the dependency and built again and rpmlint
passes without complaint. I think I must have been specifying the wrong version
to get that error before.

> > I have added %post and %postun sections to call ldconfig, as detailed in the packaging guidelines.
> 
> Since the discount package doesn't have any shared libraries, you don't need to
> call ldconfig (so remove the %post and %postun lines that aren't for
> libmarkdown).

Removed, thanks.


I have updated the spec in the same place as before and added the new SRPM. It
might be worth noting that I also made 1 other revision between my last update
here, which I have detailed in the changelog.

Spec: 
https://gist.github.com/1240217/5fd79f8bf2cb991794e0cdc43dbc23df5b7acf90

SRPM:
http://dl.dropbox.com/u/2682668/discount-2.1.2-2.fc15.src.rpm


One problem that I can still see is that 2 of the binaries probably have overly
generic names. "markdown" is used by at least 1 other package
("python-markdown") and the sample program "theme" is very generic.

I would be inclined to rename "markdown" to "discount" and "theme" to something
like "discount-theme" but I'm not really sure how naming conflicts should be
resolved. I'm just reading through the guidelines now but I thought I would
mention this now anyway.

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.