[Bug 713990] Review Request: bzr-fastimport - Bzr plugin for fast loading of data from other VCS tools

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713990

--- Comment #3 from Andy Grimm <agrimm at gmail.com> 2011-10-05 10:11:29 EDT ---
A few things:

1) Please fix the FSF address in these files (the correct address is here:
http://www.fsf.org/about/contact/ ):

$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/bzr-fastimport-0.10.0-1.fc17.noarch.rpm 
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/tests/test_generic_processor.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/cmds.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/cache_manager.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/tests/test_exporter.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/tests/test_branch_mapper.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/helpers.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/bzr_commit_handler.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/tests/test_commands.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/exporters/__init__.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/exporter.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/__init__.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/branch_mapper.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/user_mapper.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/marks_file.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/revision_store.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/processors/generic_processor.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/processors/__init__.py
bzr-fastimport.noarch: E: incorrect-fsf-address
/usr/lib/python2.7/site-packages/bzrlib/plugins/fastimport/branch_updater.py
1 packages and 0 specfiles checked; 18 errors, 0 warnings.

You should also send the change to the upstream maintainers of this project.

2) Several parts of this spec are no longer needed in recent Fedora releases,
and should be removed:

   a) "%defattr(-,root,root,-)" in the %files section
   b) the %clean section
   c) "rm -rf $RPM_BUILD_ROOT" in the %install section

3) This package does not function without python-fastimport, so it should have
a Requires line for this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.