[Bug 743615] Review Request: nagios-plugins-openmanage - Nagios plugin to monitor hardware health on Dell servers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=743615

--- Comment #2 from Trond H. Amundsen <t.h.amundsen at usit.uio.no> 2011-10-05 12:59:22 EDT ---
(In reply to comment #1)
> # No binaries here, do not build a debuginfo package
> %global debug_package %{nil}
> 
> Why is not use BuildArch: noarch?

Because I use the %{_libdir} macro. As far as I can see, the placement for
Nagios plugins in Fedora/EPEL is /usr/lib64/nagios/plugins and
/usr/lib/nagios/plugins for 64bit and 32bit arches, respectively. If not for
this, it would be a noarch package.

> URL:           http://folk.uio.no/trondham/software/%{plugin}.html
> Source0:      
> http://folk.uio.no/trondham/software/files/%{plugin}-%{version}.tar.gz
> 
> I don't see the value in using the %{plugin} macro here.

Mostly cosmetic reasons. I couldn't use %{name} :)

> BuildRequires: /usr/bin/pod2man
> 
> Well, simply using BuildRequires: perl should be safe and faster?

Maybe. If it's safer/better/preferred to use package names instead in
BuildRequires I'll change it.

> Requires:      perl(Config::Tiny)
> Requires:      perl(Net::SNMP)
> Requires:      perl(Crypt::Rijndael)
> 
> Please let rpm find these.

No, rpmbuild doesn't find these. The first two aren't found because they're
only invoked if the user requests a certain feature via options, i.e. there are
no "use Foo::Bar" that rpmbuild would find. The last one is only needed if the
user wishes to use SNMPv3 with AES. Neither the plugin nor Net::SNMP requires
it.

> You will find this page useful: 
> 
> http://fedoraproject.org/wiki/Packaging:Perl

Thanks.

> Provides:      nagios-plugins-check-openmanage = %{version}-%{release}
> Obsoletes:     nagios-plugins-check-openmanage < 3.7.2-3
> 
> Please explain the need for these lines.

I have for a long time supplied RPM packages for download (not part of a repo).
These lines are included to make the transition to Fedora/EPEL packages easier
for existing users of the RPM packages.

> %{nagiospluginsdir}/*
> %{_mandir}/man8/*.8*
> %{_mandir}/man5/*.5*
> %dir %{_sysconfdir}/nagios
> %config(noreplace) %{_sysconfdir}/nagios/*
> 
> 1)I like more explicit file list, however that's me.
> 2) I guess %dir %{_sysconfdir}/nagios is owned by nagios-plugins
> and not needed in this package?

No, %{_sysconfdir}/nagios is not owned by any package that this package
requires.

> Would be nice if you could create a FAS account and do a koji scratch build.

Yes, I will.

Thanks for your thoughts and comments :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.