[Bug 711313] Review Request: wicd-kde - a Wicd client built on the KDE Development Platform

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711313

--- Comment #18 from Kevin Kofler <kevin at tigcc.ticalc.org> 2011-10-12 10:58:17 EDT ---
> -the package contains a so file, you must call ldconfig

Wrong. The package does not install any .so file to %{_libdir}, so ldconfig is
NOT needed and should NOT be called. ldconfig does not operate on
%{_kde4_libdir}/kde4 = %{_libdir}/kde4, which is only for dlopened plugins.

Please remove the ldconfig calls again.

> -Why you don't use the kcm_wicd.desktop in the source file? By the way, there
> is a new wicd-kde release, consider upgrading your package
>
> because:
> >> error: key "Exec" is present in group "Desktop Entry", but the type is
> >> "Service" while this key is only valid for type "Application"

There is no need to run desktop-file-validate on .desktop files in
%{_kde4_datadir}/kde4/services. Those files will only ever be read by kdelibs,
so if kdelibs understands them, they're fine.

AIUI, it's normal for KCMs to have an Exec= line which runs kcmshell4 on them,
I don't think removing it is a good idea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.