[Bug 736262] Review Request: proxyfuzz - man-in-the-middle non-deterministic network fuzzer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736262

--- Comment #2 from Michal Nowak <mnowak at redhat.com> 2011-09-22 07:51:39 EDT ---
[ proxyfuzz review ]

+ URL: Should be http://www.secforce.co.uk/research/tools.html
+ Version: If the author does not claim version, use the date of the release
e.g. 20070404. For the actual release you may ask the author of review the
Windows zip package.
+ Group: Does it really work as a daemon? What about "Applications/Internet"?
+ Regarding README: 

`file' says:

/usr/share/doc/proxyfuzz-1/README: ASCII English text, with very long lines

But should say:

"ASCII text" or "UTF-8 Unicode text"

Should be named README-Fedora to indicate it's not an upstream README file. The
file should be trimmed to no more that 80 chars. 

+ License: Should be GPLv3+
+ BuildRoot: not necessary anymore
+ Patch1: we usually start with Patch0, but doesn't mather
+ description: Trim to 80 chars
+ Non need for %setup
+ rpmlint output:

[newman at dhcp-25-35 verify-that-report-edits]$ rpmlint
/home/newman/rpmbuild/RPMS/noarch/proxyfuzz-1-2.el6.noarch.rpm 
proxyfuzz.noarch: W: summary-ended-with-dot C ProxyFuzz is a man-in-the-middle
non-deterministic network fuzzer.
proxyfuzz.noarch: W: name-repeated-in-summary C ProxyFuzz
proxyfuzz.noarch: W: spelling-error %description -l en_US fuzzer -> fuzzier,
fuzzes, fuzzed
proxyfuzz.noarch: E: description-line-too-long C ProxyFuzz is a
man-in-the-middle non-deterministic network fuzzer written in Python. ProxyFuzz
randomly changes (fuzzes) contents on the network traffic. It supports TCP and
UDP protocols and can also be configured to fuzz only one side of the
communication. ProxyFuzz is protocol agnostic so it can randomly fuzz any
network communication.

+ Requieres are missing:
$ proxyfuzz 
Traceback (most recent call last):
  File "/usr/sbin/proxyfuzz", line 23, in <module>
    from twisted.protocols import portforward
ImportError: No module named twisted.protocols

+ According to https://fedoraproject.org/wiki/Packaging:Python you should
require python{2,3}-devel
+ Run rpmlint when you are happy with your changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.