[Bug 732552] Review Request: nodejs - Evented I/O for V8 JavaScript

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 29 18:02:35 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732552

--- Comment #28 from Matěj Cepl <mcepl at redhat.com> 2011-09-29 14:02:32 EDT ---
Created attachment 525610
  --> https://bugzilla.redhat.com/attachment.cgi?id=525610
reconstructed patch

(In reply to comment #27)
> The spec file in http-parser (from bug 741137) creates a .o file only rather
> than a library. Below is a hack (to illustrate only) to the node js's cmake
> input to link with this .o rather than the expected shared or static lib
> (apologies for my lack of cmake foo):

When applying the attached patch (please attach your patch, don't paste it, so
as to avoid word-wrapping), I get this error:

 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4  -m64 -mtune=generic  -rdynamic
  CPPFLAGS:            -D__POSIX__=1 -DHAVE_FDATASYNC=1 -DPLATFORM="linux"
-DX_STACKSIZE=65536 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
-DEV_MULTIPLICITY=1 -D_FORTIFY_SOURCE=2 -DHAVE_CONFIG_H=1 -DHAVE_OPENSSL=1
CMake Error: The following variables are used in this project, but they are set
to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake
files:
HTTP_PARSER_OBJ
    linked by target "node" in directory /home/matej/build/BUILD/node-v0.4.11

Also, hardcoded /usr/lib64 is probably not The Right Thing™ to do, right?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list