[Bug 809633] Review Request: perl-HTML-TreeBuilder-LibXML - HTML::TreeBuilder and XPath compatible interface with libxml

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809633

--- Comment #5 from Petr Pisar <ppisar at redhat.com> 2012-04-04 11:53:22 EDT ---
> > TODO: I recommend removing inc directory (bundled modules) and build-require
> > `perl(inc::Module::Install)' instead of `perl(ExtUtils::MakeMaker)'
> > (Makefile.PL:1).
>
> I've replaced the BR but removing the inc directory makes the build fail

That's possible. I did not checked it. Upstream sometimes puts changes which
makes inc iremovable. After quick checking, I think missing
Module::Install::AuthorTests (not yet packaged) prevents from removing the inc.

If you decide to keep the inc, you could add some new BuildRequires like Carp
or File::Spec because they are used from inc-ed code. Although they are pulled
in by inc::Module::Install either.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.