[Bug 806669] Review Request: janino - An embedded Java compiler
bugzilla at redhat.com
bugzilla at redhat.com
Fri Apr 13 13:32:18 UTC 2012
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=806669
--- Comment #12 from Mary Ellen Foster <mefoster at gmail.com> 2012-04-13 09:32:16 EDT ---
Summary:
- remove "unzip" as a BuildRequirement
- use %{name} and %{version} in source and patch file names
Otherwise, looks good
Issues:
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: unzip
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
===> Remove "unzip" as BuildRequirement
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
===> Not sure why this is warning about this; the use of the license seems fine
[!]: MUST Rpmlint output is silent.
rpmlint janino-2.6.1-4.fc18.noarch.rpm
janino.noarch: W: spelling-error %description -l en_US bytecode -> byte code,
byte-code, decorate
janino.noarch: W: spelling-error %description -l en_US evaluators -> evaluates,
evaporators, elevators
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint janino-javadoc-2.6.1-4.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint janino-2.6.1-4.fc18.src.rpm
janino.src: W: spelling-error %description -l en_US bytecode -> byte code,
byte-code, decorate
janino.src: W: spelling-error %description -l en_US evaluators -> evaluates,
evaporators, elevators
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint commons-compiler-jdk-2.6.1-4.fc18.noarch.rpm
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US codehaus
-> Wodehouse
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US
ExpressionEvaluator -> Expressionless
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US janino ->
Janine
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
===> Not a problem
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/mef3/806669/commons-compiler-2.6.1.pom :
MD5SUM this package : None
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/mef3/806669/commons-compiler-jdk-2.6.1.pom :
MD5SUM this package : cf7244a092e8f6cf9e66f620b90fc5dd
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/mef3/806669/janino-2.6.1.zip :
MD5SUM this package : bd1f9d38b8329017e469503baf53cf5b
MD5SUM upstream package : bd1f9d38b8329017e469503baf53cf5b
/home/mef3/806669/janino-2.6.1.pom :
MD5SUM this package : 968962e5591e36bbec8696f70443b5f3
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
See: http://fedoraproject.org/wiki/Packaging/SourceURL
===> This is because you can't wget files from repo1.maven.org with the default
user agent. I
tried downloading them myself manually and got this, which matches the files in
the SRPM:
f99e0f69541e17c8f160799b056720b4 commons-compiler-2.6.1.pom
cf7244a092e8f6cf9e66f620b90fc5dd commons-compiler-jdk-2.6.1.pom
968962e5591e36bbec8696f70443b5f3 janino-2.6.1.pom
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: unzip
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST License file installed when any subpackage combination is installed.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint janino-2.6.1-4.fc18.noarch.rpm
janino.noarch: W: spelling-error %description -l en_US bytecode -> byte code,
byte-code, decorate
janino.noarch: W: spelling-error %description -l en_US evaluators -> evaluates,
evaporators, elevators
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint janino-javadoc-2.6.1-4.fc18.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint janino-2.6.1-4.fc18.src.rpm
janino.src: W: spelling-error %description -l en_US bytecode -> byte code,
byte-code, decorate
janino.src: W: spelling-error %description -l en_US evaluators -> evaluates,
evaporators, elevators
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint commons-compiler-jdk-2.6.1-4.fc18.noarch.rpm
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US codehaus
-> Wodehouse
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US
ExpressionEvaluator -> Expressionless
commons-compiler-jdk.noarch: W: spelling-error %description -l en_US janino ->
Janine
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
[!]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/mef3/806669/commons-compiler-2.6.1.pom :
MD5SUM this package : None
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/mef3/806669/commons-compiler-jdk-2.6.1.pom :
MD5SUM this package : cf7244a092e8f6cf9e66f620b90fc5dd
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
/home/mef3/806669/janino-2.6.1.zip :
MD5SUM this package : bd1f9d38b8329017e469503baf53cf5b
MD5SUM upstream package : bd1f9d38b8329017e469503baf53cf5b
/home/mef3/806669/janino-2.6.1.pom :
MD5SUM this package : 968962e5591e36bbec8696f70443b5f3
MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
justified.
[!]: SHOULD SourceX / PatchY prefixed with %{name}.
Note: Source0: http://dist.codehaus.org/janino/janino-2.6.1.zip
(janino-2.6.1.zip) Source1: janino-2.6.1-aggregator-01.pom
(janino-2.6.1-aggregator-01.pom) Source2:
http://repo1.maven.org/maven2/org/codehaus/janino/commons-compiler/2.6.1
/commons-compiler-2.6.1.pom (commons-compiler-2.6.1.pom) Source3:
http://repo1.maven.org/maven2/org/codehaus/janino/commons-compiler-
jdk/2.6.1/commons-compiler-jdk-2.6.1.pom (commons-compiler-jdk-2.6.1.pom)
Source4:
http://repo1.maven.org/maven2/org/codehaus/janino/janino/2.6.1/janino-2.6.1.pom
(janino-2.6.1.pom) Patch0: janino-2.6.1-pom.patch
(janino-2.6.1-pom.patch)
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[x]: SHOULD Packages should try to preserve timestamps of original installed
files.
[x]: SHOULD Spec use %global instead of %define.
==== Java ====
[x]: MUST If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils
[x]: MUST Fully versioned dependency in subpackages, if present.
[x]: MUST Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: MUST Javadoc subpackages have Requires: jpackage-utils
[x]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version}
symlink)
[x]: SHOULD Package has BuildArch: noarch (if possible)
[x]: SHOULD Package uses upstream build method (ant/maven/etc.)
==== Maven ====
[x]: MUST Pom files have correct add_maven_depmap call
Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: MUST Old add_to_maven_depmap macro is not being used
[x]: MUST Packages DOES NOT have Requires(post) and Requires(postun) on
jpackage-utils for %update_maven_depmap macro
[x]: MUST Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: MUST Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
Generated by fedora-review 0.1.3
External plugins:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list