[Bug 811418] Review Request: rubygem-hydra - distributes tests for speed

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=811418

Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #7 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> 2012-04-25 09:22:28 EDT ---
(In reply to comment #6)
> Latest round:
> 
> Spec URL: http://matthicksj.fedorapeople.org/reviews/rubygem-hydra.spec
> 
> SRPM URL:
> http://matthicksj.fedorapeople.org/reviews/rubygem-hydra-0.24.0-1.fc16.src.rpm
> 
> I've updated the conditions to use el5 / el6.
> 
> Had one question around the 'Requires: rubygems'.  In the old packaging
> guidelines, they had:
> 
> The package must have a Requires and a BuildRequires on rubygems
> 
> However, I used the format above 'Requires: ruby(rubygems)' as I saw that used
> in a couple of other RPM's.  Any advice on the right approach?  I could do the
> following:
> 
> 1. Change 'Require: ruby(rubygems)' to 'Require: rubygems'.  That would meet
> the old ruby packaging guidelines and I believe should functionally work.
> 

Yes, that is the safest way, but I believe that all rubygems packages in
relevant versions of systems also provide ruby(rubygems), so it shouldn't
matter.

> 2. I could modify the conditional to include the following
> 
> %if 0%{?el5}%{?el6}
> Requires: rubygems
> BuildRequires: rubygems
> %else
> Requires: ruby(rubygems)
> BuildRequires: rubygems-devel
> %endif
> 
> Thanks again for your help

Yes, but again, I think that requiring just rubygems is a safe option.
Also, if you are planning to use the gem on Fedora 16 or 15, you will have to
use the same as in RHEL 5 and 6. (You can achieve that similarly as with
%{?el5}%{?el6}...)

Anyway, this package looks good now and is APPROVED. (please make the changes
before committing).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.