[Bug 840602] Review Request: maradns - Authoritative and recursive DNS server made with security in mind

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=840602

--- Comment #1 from Matthieu Saulnier <casper.le.fantom at gmail.com> ---
Hello, sorry for the latence.
Some remarks:

* Don't add systemd unit files using a patch, add them using Source1,
  Source2 and Source3 tags. However, your patch is good to modify
  build/install.sh file properly.

* Group tag is useless, you can remove it.
  https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag

* Use "make" instead of %{__make}, "install" instead of %{__install},
  "rm" instead of %{__rm}, and "sed" instead of %{__sed}.
  https://fedoraproject.org/wiki/Packaging:Guidelines#Macros

* You can remove the script in %install section:
    %{__rm} CHANGELOG CREDITS FAQ
    ln -fs en/changelog.txt CHANGELOG
    ln -fs en/credits.txt CREDITS
    ln -fs en/faq.txt FAQ
  Because these files are already symbolic links:
    $ file CHANGELOG CREDITS FAQ
    CHANGELOG: symbolic link to `doc/en/changelog.txt'
    CREDITS:   symbolic link to `doc/en/credits.txt'
    FAQ:       symbolic link to `doc/en/faq.txt'

* There is some duplicate files in the rpm with the actual %doc line, it
  would better like this:
    %doc COPYING doc/en/changelog.txt doc/en/credits.txt doc/en/faq.txt
doc/en/{examples,tutorial,webpage}

* You can remove "%doc maradns.gpg.key" line, the source tarball is not
  signed.

* In %post section, you can replace 's/\/etc\/deadwood/\/var\/cache\/deadwood/'
  by 's@/etc/deadwood@/var/cache/deadwood@'

-- 
You are receiving this mail because:
You are on the CC list for the bug.