[Bug 844080] Review Request: libmatecomponent -- Libraries for matecomponent package of MATE-Desktop

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 11 02:46:41 UTC 2012


https://bugzilla.redhat.com/show_bug.cgi?id=844080

--- Comment #21 from Rex Dieter <rdieter at math.unl.edu> ---
1.   SHOULD make -libs subpkg for shared libraries.  else,  the main pkg is
going to get  multilib'd, and will likely lead to  multilib conflicts

2.  MUST include  in %files:
%{_libdir}/matecomponent-2.0/
%{_libdir}/matecomponent/
so this will get owned, as well as everything recursively under it

same goes  for
%{_libdir}/matecorba-2.0/
if nothing else lower in the stack owns this dir.

3.   MUST include in %files devel
%{_includedir}/libmatecomponent-2.0/
%{_includedir}/matecomponent-activation-2.0/
(so this will get owned, as well as everything recursively under it)

4.  SHOULD: -devel remove
%doc AUTHORS COPYING README
no need do duplicate the same stuff from the main pkg

5. SHOULD do verbose %build, use
make ... V=1

naming:  ok

scriptlets: ok

macros: ok

sources: ok
7ba05884fec91eb5c3bb2cf7300b0e16  libmatecomponent-1.4.0.tar.xz


address at least MUST items 2,3, and we're pretty close.

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the package-review mailing list