[Bug 849200] Review Request: connman - A daemon for managing internet connections on Linux
bugzilla at redhat.com
bugzilla at redhat.com
Fri Aug 17 23:18:34 UTC 2012
https://bugzilla.redhat.com/show_bug.cgi?id=849200
Michael Scherer <misc at zarb.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody at fedoraproject.org |misc at zarb.org
Flags| |fedora-review?
--- Comment #4 from Michael Scherer <misc at zarb.org> ---
A few others notes :
- license is not shipped with the rpms
- there is a test suite shipped with connman, could it be run in %check
For the rest, this is good, so if you fix the 4 issues, I will approve the
package.
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
===== MUST items =====
C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Permissions on files are set properly.
[x]: Package does not contain duplicates in %files.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: Large documentation files are in a -doc subpackage, if required.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2)", "GPL (v2 or later)" For detailed output of licensecheck see
file:
/home/misc/checkout/git/FedoraReview/849200-connman/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[x]: Package does not generate any conflict.
Note: Package contains no Conflicts: tag(s)
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Package requires pkgconfig, if .pc files are present. (EPEL5)
Note: Only applicable for EL-5
[x]: Requires correct, justified where necessary.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
===== SHOULD items =====
Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL5 is required
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr macros not found. They would be needed for EPEL5
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
Issues:
=======
[!]: %check is present and all tests pass.
[!]: Package must own all directories that it creates.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License file installed when any subpackage combination is installed.
Rpmlint
-------
Checking: connman-1.5-1.fc17.x86_64.rpm
connman-devel-1.5-1.fc17.x86_64.rpm
connman-1.5-1.fc17.src.rpm
connman-debuginfo-1.5-1.fc17.x86_64.rpm
connman.x86_64: W: only-non-binary-in-usr-lib
connman.x86_64: W: no-manual-page-for-binary connmand
connman.x86_64: W: percent-in-%post
connman.x86_64: W: percent-in-%preun
connman.x86_64: W: percent-in-%postun
connman-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:
Diff spec file in url and in SRPM
---------------------------------
--- /home/misc/checkout/git/FedoraReview/849200-connman/srpm/connman.spec
2012-08-18 01:01:18.812369205 +0200
+++
/home/misc/checkout/git/FedoraReview/849200-connman/srpm-unpacked/connman.spec
2012-08-18 01:01:22.362396886 +0200
@@ -2,5 +2,5 @@
Version: 1.5
Release: 1%{?dist}
-Summary: An alternative daemon for managing internet connections on Linux
+Summary: A daemon for managing internet connections on Linux
Group: System Environment/Base
Requires
--------
connman-1.5-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
/bin/sh
config(connman) = 1.5-1.fc17
libc.so.6()(64bit)
libdbus-1.so.3()(64bit)
libdl.so.2()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3.1)(64bit)
libglib-2.0.so.0()(64bit)
libgnutls.so.26()(64bit)
libgnutls.so.26(GNUTLS_1_4)(64bit)
libpthread.so.0()(64bit)
libresolv.so.2()(64bit)
librt.so.1()(64bit)
libxtables.so.7()(64bit)
rtld(GNU_HASH)
systemd-units
wpa_supplicant >= 1.0
connman-devel-1.5-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
pkgconfig(dbus-1)
pkgconfig(glib-2.0)
connman-debuginfo-1.5-1.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
Provides
--------
connman-1.5-1.fc17.x86_64.rpm:
config(connman) = 1.5-1.fc17
connman = 1.5-1.fc17
connman(x86-64) = 1.5-1.fc17
connman-devel-1.5-1.fc17.x86_64.rpm:
connman-devel = 1.5-1.fc17
connman-devel(x86-64) = 1.5-1.fc17
pkgconfig(connman) = 1.5
connman-debuginfo-1.5-1.fc17.x86_64.rpm:
connman-debuginfo = 1.5-1.fc17
connman-debuginfo(x86-64) = 1.5-1.fc17
MD5-sum check
-------------
http://www.kernel.org/pub/linux/network/connman/connman-1.5.tar.xz :
CHECKSUM(SHA256) this package :
f973198e90083a30a7c8233cfe87ddf77bb40eac1ba8d8733b9b75131aec1e94
CHECKSUM(SHA256) upstream package :
f973198e90083a30a7c8233cfe87ddf77bb40eac1ba8d8733b9b75131aec1e94
Generated by fedora-review 0.2.0 (a5c4ced) last change: 2012-07-22
Command line :./try-fedora-review -b 849200
External plugins:
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the package-review
mailing list