[Bug 848211] Review Request: mirall - owncloud desktop client

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=848211

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #12 from Rex Dieter <rdieter at math.unl.edu> ---
licensing: ok

scriptlets:  ok

macros: ok

3. SHOULD remove 
-DCMAKE_INSTALL_PREFIX=%{_prefix} -DCMAKE_INSTALL_SYSCONFDIR=%{_sysconfdir}
the default %cmake macro already includes these

otherwise, good work.  3 can be fixed post-review.


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.