[Bug 839395] Review Request: rubygem-openshift-origin-controller - Rails engine for the OpenShift Broker API

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=839395

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #28 from Vít Ondruch <vondruch at redhat.com> ---
(In reply to comment #27)
Well that was my suggestion towards upstream. I don't think we should take any
action in Fedora in that direction and we should wait until new upstream gem
release will be available.

It is probably not good idea to have in Fedora gem, which claims it is 0.14.15
version, but it differs in behavior from upstream gem.

(In reply to comment #26)
Brenton,

* I see that you add a Require: rubygem(mongo)? Shouldn't it be referenced in
the .gemspec file as well? Shouldn't it be reported upstream? The .gemspec
dependencies should be aligned with .spec requires, if there is no special
reason.


Nevertheless, this is minor issue and the package looks good now => APPROVE.
Brenton, please clarify with upstream the mongo requirements before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.