[Bug 807479] Review Request: spacewalk-setup-jabberd - Tools to setup jabberd for Spacewalk

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=807479

--- Comment #12 from Mario Blättermann <mario.blaettermann at gmail.com> ---
(In reply to comment #11)
> spacewalk-setup-jabberd.src: I: checking-url
> https://fedorahosted.org/releases/s/p/spacewalk/spacewalk-setup-jabberd-1.8.
> 5.tar.gz (timeout 10 seconds)
> 
> I can download it without problem.
Me too. There was no error message at all. The timeout is just a hint.
> 
> > %{_sysconfdir}/pki/spacewalk
> > has to be
> > %config(noreplace) %{_sysconfdir}/pki/spacewalk
> 
> There are no config files. It is just two directories.
> If you insist, I can rewrite it to:
> %dir %{_sysconfdir}/pki/spacewalk
> %dir %{_sysconfdir}/pki/spacewalk/jabberd
> But the former formulation is one line shorter :)

No, the folder ownership is OK. I think the folder itself should be marked as
(noreplace) to avoid to be overwritten by rpm when updating the package. For
the time being, the folder is empty, but once it contains config files, they
could get lost.

-- 
You are receiving this mail because:
You are on the CC list for the bug.