[Bug 852851] Review Request: jacorb - The Java implementation of the OMG's CORBA standard

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=852851

--- Comment #3 from Marek Goldmann <mgoldman at redhat.com> ---
(In reply to comment #1)

> Issues:
> 
> 1. License file exists under "doc" directory along with other documentation
> files. These need to be added to the package in %doc section.

Added! Totally forgot about this one.

> 2. This does not appear to be the latest version of the package available.
> I'm assuming that this version is needed for compatibility with another
> package. If that's not the case, please package the newer version.

You're correct this is a special version required by JBoss AS. I hope to remove
the dependency on Jacorb in the future. But it'll take some time.

> 3. Patches should be prefixed with %{name}. This isn't a big deal, but fix
> if you can.

I explained it in another review, but I'm happy to do this once again:

1. These patches are generated by git and git prefixes them with the numbers.
2. These numbers let you know which patches should be applied first.
3. Numbering in front makes it easy to understand the patch order when looking
at the sources directory.
4. Every patch is put in Fedora in a repository of a special name (in this case
'jacorb'), there is no need to duplicate the name in patches.

Hope this makes my POV more clear. I would like to stick with the numbering.

> 4. Minor typo in the %description section. "containse" should be "contains".

Fixed!

> 5. RPMLint is warning of class-path-in-manifest in the jar file.

Fixed!

> 6. The README specifies that the jar can be built with "ant -Ddebug=off all
> doc" to avoid building in debug mode. This should probably be done. I assume
> there is no need for debug mode since Java does not generate a debuginfo
> package.

Skipped, as per comment #2.

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4436898

Spec URL:
http://goldmann.fedorapeople.org/package_review/jacorb/2.3.1-2.20120215git/jacorb.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/jacorb/2.3.1-2.20120215git/jacorb-2.3.1-2.20120215git.fc17.src.rpm

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.