[Bug 882418] Review Request: php-Pimple - A simple Dependency Injection Container for PHP 5.3

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=882418

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #2 from Remi Collet <fedora at famillecollet.com> ---
Tips: you could simply use (in bootstrap.php)
require_once 'Pimple/Pimple.php';

On so, rely on standard php include_path. 
During the check, you can override this value (to avoid another sed)

phpunit -d include_path=%{buildroot}%{_datadir}/php:.:%{pear_phpdir} ...


Please consider removing "5.3" from Summary and %description.
This seems really "restrictive", and it works perfectly with PHP 5.5.0.


I don't see any blockers,

=== APPROVED ====

-- 
You are receiving this mail because:
You are on the CC list for the bug.