[Bug 799702] Review Request: python-ufl - A compiler for finite element variational forms

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=799702

--- Comment #7 from Fabian Affolter <mail at fabian-affolter.ch> ---
(In reply to comment #6)
> Issues:
> =======
> [!]: Package installs properly.
>      Note: Installation errors (see attachment)
> See: https://fedoraproject.org/wiki/Packaging:Guidelines
> 
> [!]: License file installed when any subpackage combination is installed.
> >>>> Licence file missing from demo and test packages. Please note that
> >>>> the actual licence file is COPYING.LESSER, while COPYING is provided
> >>>> for files used at compile time, which are not included in the final
> >>>> package.

License files added

> [!]: %check is present and all tests pass.
> >>>> Check section is commented out. Please, either uncomment it or provide
> >>>> reasons why tests aren't being run.

%check removed 

> [!]: Requires correct, justified where necessary.
> >>>> Test subpackage requires python2-nose. Should be python-nose

Fixed

> [!]: Permissions on files are set properly.
> >>>> E. g. /usr/lib/python2.7/site-packages/ufl/test/test_lhs_rhs.py does not
> >>>> have the +x permission. I didn't check if the file is to be run, but 
> >>>> since it has a shebang, I guess it is. Please also check these files:
> >>>> /usr/lib/python2.7/site-packages/ufl/test/test_book_snippets.py
> >>>> /usr/lib/python2.7/site-packages/ufl/test/test_tensoralgebra.py
> >>>> /usr/lib/python2.7/site-packages/ufl/test/ufltestcase.py

Fixed

> >>>> Moreover, the file /usr/lib/python2.7/site-packages/ufl/demo/clean.sh
> >>>> from the demo subpackage is not executable. Please, change that.

Fixed

[fab at laptop11 SRPMS]$ rpmlint python-ufl-1.0.0-4.fc17.src.rpm 
python-ufl.src: W: spelling-error Summary(en_US) variational -> variation,
variegation, motivational
python-ufl.src: W: spelling-error %description -l en_US discretizations ->
indiscretions, discretionary, discolorations
python-ufl.src: W: spelling-error %description -l en_US variational ->
variation, variegation, motivational
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[fab at laptop11 noarch]$ rpmlint python-ufl*
python-ufl.noarch: W: spelling-error Summary(en_US) variational -> variation,
variegation, motivational
python-ufl.noarch: W: spelling-error %description -l en_US discretizations ->
indiscretions, discretionary, discolorations
python-ufl.noarch: W: spelling-error %description -l en_US variational ->
variation, variegation, motivational
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

Updated packages:
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-ufl.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-ufl-1.0.0-4.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L5u3CQUtmg&a=cc_unsubscribe