[Bug 773511] Review Request: linuxdcpp - A file-sharing client for the Direct Connect network

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=773511

František Dvořák <valtri at civ.zcu.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |valtri at civ.zcu.cz
             Blocks|                            |177841 (FE-NEEDSPONSOR)

--- Comment #4 from František Dvořák <valtri at civ.zcu.cz> ---
If I'm not mistaken, you would need a sponsor? Blocks field updated.

Quick informal check of the packaging:

[valtri at forkys results]$ rpmlint *.rpm
linuxdcpp.x86_64: E: non-standard-executable-perm /usr/bin/linuxdcpp 0775L
3 packages and 0 specfiles checked; 1 errors, 0 warnings.

1. MUST: Permissions on files must be set properly.

The problem is probably the write access for the group.

2. MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.

See
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage

3. These items are not needed for Fedora or EPEL >= 6. You can consider
removing them, but it is not a blocker:

'Group:' tag
'BuildRoot:' tag
'%defattr' tag
'%clean' section
rm -rf %{buildroot} (from beginning of '%install' section)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Febv1tgMz1&a=cc_unsubscribe