[Bug 886261] Review Request: php-when - Date/Calendar recursion library for PHP 5.2+

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=886261

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com

--- Comment #1 from Remi Collet <fedora at famillecollet.com> ---
As the Test suite is provided, you should run it during %check.

For now, test suite isn't compatible with latest PHPUnit (use some deprecated
include).

so, for example, in %prep, remove this include, and fix the other include path

sed -e '/Framework.php/d' \
    -e '/When.php/s:./:when/:' \
    -e '/When_Iterator.php/s:./:when/:' \
    -i Tests/*php

and in %check
cd Tests
phpunit -d
include_path=%{buildroot}%{_datadir}/php:.:%{_datadir}/php:%{_datadir}/pear .


Please don't install tests in /usr/share/php, which is part of the default
include_path.
Better solution is to use /usr/share/tests/when

You need to own the /usr/share/tests directory (or require pear which own it)

Please consider removing "5.2+" from summary, PHP is enough.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gRSyD1zSnO&a=cc_unsubscribe