[Bug 855605] Review Request: hexchat - GTK IRC Client

[bugzilla at redhat.com]

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=855605

--- Comment #9 from Dan Mashal <dan.mashal at gmail.com> ---
Naming: OK
Licensing: OK GPLv2+ covers all the files in the tarball.

MUST:

Drop the following BRs: perl, autoconf, pkgconfig, gettext, bison 
Drop: dbus-devel (dbus-glib-devel) provides this.

Switch: perl(ExtUtils::Embed) to perl-ExtUtils-Embed
Add: intltool, libtool

Switch: "make %{?_smp_mflags}" to "make %{?_smp_mflags} V=1"


As per: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets

For icons and update-desktop-database switch to the following:

%post
/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
/usr/bin/update-desktop-database &> /dev/null || :

%postun
/usr/bin/update-desktop-database &> /dev/null || :
if [ $1 -eq 0 ] ; then
    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

%posttrans
/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :


SHOULD: Fix incorrect FSF addresses.

Unless packaging for EPEL5 DROP:

Drop:
%clean
rm -rf $RPM_BUILD_ROOT

Drop:
-rf $RPM_BUILD_ROOT from %install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gsNrQucqwZ&a=cc_unsubscribe