[Bug 771233] Review Request: rubygem-rack-protection - Ruby gem that protects against typical web attacks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771233

--- Comment #7 from Michal Fojtik <mfojtik at redhat.com> 2012-01-04 06:24:51 EST ---
(In reply to comment #6)
> > > - Move %{geminstdir}/README.md to the -doc subpackage, if it is not needed for
> > > runtime (which I believe it isn't) and mark it with %doc.
> > > - Also, mark %{gemdir}/doc/%{gemname}-%{version} with %doc.
> > 
> > Actually I don't think marking -doc subpackage files with %doc is necessary.
> > Could you point me to a guideline where this is required?
> 
> I believe that there is no specific guideline for this. But if you take a look
> at it from the logical point of view, you have two types of files in  your -doc
> subpackage:
> - The Rakefile and spec/ directory, which are not needed for runtime, so you
> moved them to -doc subpackage (which is completely ok, I think), but they are
> not documentation.
> - The real documentation (README.md and the doc directory).
> So, to me, it makes sense to distinct these two.

Good point. My general through was that once the subpackage is marked as '-doc'
the files are already recognized as %doc and thus don't need additional
marking.

Anyway, I'll mark them, not a blocker for me of course ;-)

> Additional comments:
> - I think it is clearer not to remove the files by "rm", but use %exclude in
> %files. But this is just my opinion, so not a blocker.
> - As for the macros vs. commands thing: There are also macros for commands like
> "rm", so it may be good to use them, once you decide to use macros for some
> commands. But at this stage, it doesn't have the feeling of inconsistency, so
> not a blocker. (BTW, I think that using macros for things like "mkdir -p" is
> not necessary, but again, just my opinion.)
> - The link in comment #5 points to the first release srpm, so when importing to
> fedpkg, please make sure to import the second one :)

Sure, I'll try to fix that before importing to Fedora (EPEL). Thanks for review
Bohuslav!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.