[Bug 772709] Review Request: TeXamator - Helping you making your exercise sheets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=772709

--- Comment #7 from Mohamed El Morabity <pikachu.2014 at gmail.com> 2012-01-12 20:38:56 EST ---
All the Python files in %{_datadir}/%{name}/ are libraries, NOT executables
(except %{name}.py). They MUST not be executable in any way.
I suppose the shebang trick in the page I gave you above didn't work. This
trick supposes that the shebang contains « /usr/bin/env/ », whereas the
incrimined files in your package have « /usr/bin/python ». You should adapt it
as below instead:

for lib in %{buildroot}%{_datadir}/%{name}/partielatormods/*/*.py
%{buildroot}%{_datadir}/%{name}/partielatormods/*.py; do
 sed '/\/usr\/bin\/python/d' $lib > $lib.new &&
 touch -r $lib $lib.new &&
 mv $lib.new $lib
done

I suggest you also to comment all the fixes you include in you .spec, to help
those who would read it... And for you to remember why you made the fix ^^.

About this fix:
   find -name '*~' -print0 | xargs -0 -r -l512 rm -f
I suggest you to use this shorter command instead
   find -name '*~' -delete
Move this on in %prep, it's probably a better place to call it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.