[Bug 785441] Review Request: php-horde-Horde-Nls - Native Language Support (NLS)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=785441

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2012-01-30 13:48:42 EST ---
--- php-horde-Horde-Nls.spec.old 2012-01-30 19:38:29.000000000 +0100
+++ php-horde-Horde-Nls.spec 2012-01-30 19:46:15.000000000 +0100
@@ -12,14 +12,15 @@
 Source0:        http://pear.horde.org/get/%{pear_name}-%{version}.tgz

 BuildArch:      noarch
-BuildRequires:  php-pear >= 1:1.4.9-1.2
+BuildRequires:  php-pear(PEAR) >= 1.7.0
+BuildRequires:  php-channel(pear.horde.org)
+
 Requires(post): %{__pear}
 Requires(postun): %{__pear}
-Requires:       php-pear(pear.horde.org/Horde_Translation) <= 2.0.0,
php-pear(pear.horde.org/Horde_Util) <= 2.0.0, php-pear(PEAR) >= 1.7.0
-Conflicts:      php-pear(pear.horde.org/Horde_Translation) = 2.0.0,
php-pear(pear.horde.org/Horde_Util) = 2.0.0
-Provides:       php-pear(pear.horde.org/Horde_Nls) = %{version}
-BuildRequires:  php-channel(pear.horde.org)
-Requires:       php-channel(pear.horde.org)
+Requires:       php-pear(pear.horde.org/Horde_Util) >= 1.0.0
+Requires:       php-pear(pear.horde.org/Horde_Util) <  2.0.0
+Requires:       php-pear(PEAR) >= 1.7.0
+Provides:       php-pear(pear.horde.org/%{Horde_Nls}) = %{version}



I propose to remove Horde_Translation, already required by dependency of
Horde_Util (you could keep it, if you think "versionning" have some value)

Requiring the channel not needed (I miss to drop this on other packages, except
Translation which don't requires other horde package)

+ must handle locales

NB optional dep on Net_DNS2 (not yet available in fedora) and geoip
(available). As rpm doesn't handle optional dep, I always think of adding this
are normal dep (when not pull to much things => but this is your choice

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.