[Bug 836708] Review Request: sugar-locosugar - a game for discovering how to use the mouse and keyboard

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=836708

--- Comment #2 from Dan Callaghan <dcallagh at redhat.com> ---
A couple of issues at the bottom.


Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint sugar-locosugar-3-1.fc18.noarch.rpm

sugar-locosugar.noarch: W: non-standard-group Sugar/Activities
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint sugar-locosugar-3-1.fc18.src.rpm

sugar-locosugar.src: W: non-standard-group Sugar/Activities
sugar-locosugar.src: W: strange-permission sugar-locosugar.spec 0600L
sugar-locosugar.src:32: W: macro-in-comment %find_lang
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/dan/fedora/reviews/836708/LocoSugar-3.tar.bz2 :
  MD5SUM this package     : 417443c5a2136f693b52d395089aea46
  MD5SUM upstream package : 417443c5a2136f693b52d395089aea46

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[-]: SHOULD %check is present and all tests pass.
[-]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Remove %defattr if not targetting EPEL5.
[!]: MUST License field in the package spec file matches the actual license.
License should be "GPLv3+ and LGPLv2.1+ and MIT". sprites.py (another copy..!)
is under MIT, play_audio.py is under LGPLv2.1+.
[!]: MUST Rpmlint output is silent.
Remove the commented-out locale bits from the spec. Non-standard group and
tarball permissions are fine.

rpmlint sugar-locosugar-3-1.fc18.noarch.rpm

sugar-locosugar.noarch: W: non-standard-group Sugar/Activities
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


rpmlint sugar-locosugar-3-1.fc18.src.rpm

sugar-locosugar.src: W: non-standard-group Sugar/Activities
sugar-locosugar.src: W: strange-permission sugar-locosugar.spec 0600L
sugar-locosugar.src:32: W: macro-in-comment %find_lang
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
[!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
Same issue with /usr/bin/env as bug 823234 and bug 823236.


Generated by fedora-review 0.1.3
External plugins:

-- 
You are receiving this mail because:
You are on the CC list for the bug.