[Bug 831975] Review Request: guacamole-common-js - The JavaScript library used by the Guacamole web application

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=831975

--- Comment #3 from Simone Caronni <negativo17 at gmail.com> ---
Hello,

thanks for taking the review.

The package itself should not build, hence the empty %build section. According
to the java script packaging guidelines [1]; javascript "bundles" should not be
built and just parked into the filesystem.

Updated package with "rm -rf %{buildroot}" removed:

Spec URL: http://slaanesh.fedorapeople.org/guacamole-common-js.spec
SRPM URL:
http://slaanesh.fedorapeople.org/guacamole-common-js-0.6.0-2.fc17.src.rpm

Unfortunately there's no way to test it, I need these javascripts to build the
Guacamole main web application which is another package I'm struggling to build
with other draft guidelines. I kindly ask to do the formal review only.

Beside of this, the command you're looking for is "mvn-rpmbuild"; instead of
downloading stuff it checks if prerequisites are already in place through rpm
dependency [2],[3].

[1]
https://fedoraproject.org/wiki/JavaScript_libraries_packaging_guideline_draft

[2]
http://pkgs.fedoraproject.org/gitweb/?p=guacamole-common.git;a=blob_plain;f=guacamole-common.spec;hb=HEAD

[3]
http://pkgs.fedoraproject.org/gitweb/?p=guacamole-ext.git;a=blob_plain;f=guacamole-ext.spec;hb=HEAD

Thanks,
--Simone

-- 
You are receiving this mail because:
You are on the CC list for the bug.