[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=817315

--- Comment #14 from Simone Caronni <negativo17 at gmail.com> ---
Issues:

[!]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
     Note: The package did not built BR could therefore not be checked or the
     package failed to build because of missing BR
[!]: SHOULD Reviewer should test that the package builds in mock.

Currently it doesn't build. Dependencies are ok, but the build does not
succeed, see comment #12.


[!]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.

There's no license file packaged in the %doc directive, but is correctly
shipped inside the archive. Please add the following to the %files section:

%files
%doc AUTHORS.source_code.txt
%doc CHANGELOG.txt
%doc COPYRIGHT.source_code.txt
%doc gnu_gpl_3.0.txt
%doc README.txt

Release management and compiling docs are not useful inside the pre-compiled
binary rpm we'll be installing.


[!]: MUST Package must own all directories that it creates.
[!]: MUST Package does not own files or directories owned by other packages.

The files section relies on files in the megaglest folder, by adding the
megagles folder itself you ensure the directory is owned by the base megaglest
package and the megaglest-data package can rely on it for installing. See the
other review for the details.

%files
%{_datadir}/megaglest


[!]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
     http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

As per the megaglest-data review, the sourceforge url downloads an html file,
according to the packaging guidelines sourceforge urls' should be explicitly
declared as in the packaging guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.