[Bug 817315] Review Request: megaglest - Open Source 3d real time strategy game

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=817315

--- Comment #20 from Simone Caronni <negativo17 at gmail.com> ---
Hello,

a couple of other issues regarding BuildRequires, I have attached a patch that
corrects the following:


1) The jpeg dependency is wrong, it is not "turbojpeg-devel" but
"libjpeg-turbo-devel", only this way the turbojpeg headers are installed.


2) The command "desktop-file-validate" is part of "desktop-file-utils, so that
needs to be a requirement as well.


3) The %{_iconsdir} macro is not evaluated unless you install the
"jpackage-utils", here is the failure of the build in koji, look at the bottom:

http://kojipkgs.fedoraproject.org//work/tasks/8581/4238581/build.log

So if you want to use macros such as %{_iconsdir}, "BuildRequires:
jpackage-utils" is needed to make it sure that /etc/rpm/macros.jpackage surely
exists.

However
- This package does not seem to be related to Java
- So adding "BR: jpackage-utils" just to define %{_iconsdir} is not desired
- Also almost all packages on Fedora install files under %{_datadir}/icons/

So replacing %{_iconsdir} with %{_datadir}/icons is much preferable.

A simple 's|%{_iconsdir}|%{_datadir}/icons|g' in the spec file fixes the issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.