[Bug 831929] Review Request: grub-customizer - Grub Customizer is a graphical interface to configure the grub2/burg settings

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=831929

leigh scott <leigh123linux at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |leigh123linux at googlemail.co
                   |                            |m

--- Comment #2 from leigh scott <leigh123linux at googlemail.com> ---
1. You need to validate the desktop file

https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files


2. You need to add a scriptlet to update the icon cache

https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache 


3. You need to remove BuildRequires:  gcc-c++

https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2


4. You have mixed use of %{buildroot} and $RPM_BUILD_ROOT, use one only.


5. You need to remove the .R from the changelog


* Thu Jun 14 2012 Vasiliy N. Glazov <vascom2 at gmail.com> 2.5.7-1.R

-- 
You are receiving this mail because:
You are on the CC list for the bug.