[Bug 836749] Review Request: objconv - object file converter and disassembler
bugzilla at redhat.com
bugzilla at redhat.com
Wed Jul 18 10:22:30 UTC 2012
https://bugzilla.redhat.com/show_bug.cgi?id=836749
David Cameron <d.g.cameron at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |d.g.cameron at gmail.com
--- Comment #3 from David Cameron <d.g.cameron at gmail.com> ---
Hi,
Here is a first (informal) review:
Package Review
==============
Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated
==== C/C++ ====
[x]: MUST Header files in -devel subpackage, if present.
[x]: MUST Package does not contain any libtool archives (.la)
[x]: MUST Package does not contain kernel modules.
[x]: MUST Package contains no static executables.
[x]: MUST Rpath absent or only used for internal libs.
[x]: MUST Package is not relocatable.
==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
least one supported primary architecture.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[-]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[!]: MUST Spec file lacks Packager, Vendor, PreReq tags.
Note: Found : Vendor: Agner Fog
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[!]: MUST License field in the package spec file matches the actual license.
Note: Upstream website states license as GPL, while in spec it is GPLv3+
[x]: MUST Package consistently uses macros (instead of hard-coded directory
names).
[x]: MUST Package meets the Packaging Guidelines.
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generates any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[-]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[-]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.
rpmlint objconv-debuginfo-2.14-1.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint objconv-2.14-1.fc18.i686.rpm
objconv.i686: W: spelling-error Summary(en_US) disassembler -> disassemble,
disassembles, disassembled
objconv.i686: W: spelling-error %description -l en_US disassembler ->
disassemble, disassembles, disassembled
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint objconv-2.14-1.fc18.src.rpm
objconv.src: W: spelling-error Summary(en_US) disassembler -> disassemble,
disassembles, disassembled
objconv.src: W: spelling-error %description -l en_US disassembler ->
disassemble, disassembles, disassembled
objconv.src:30: E: files-attr-not-set
objconv.src:31: E: files-attr-not-set
objconv.src: W: no-cleaning-of-buildroot %install
objconv.src: W: no-cleaning-of-buildroot %clean
objconv.src: W: no-buildroot-tag
objconv.src: W: no-%clean-section
1 packages and 0 specfiles checked; 2 errors, 6 warnings.
[x]: MUST Sources used to build the package match the upstream source, as
provided in the spec URL.
/home/mock/836749/objconv-2.14.tar.gz :
MD5SUM this package : 211614a017ace5c196fcd3ffe6db3b45
MD5SUM upstream package : 211614a017ace5c196fcd3ffe6db3b45
[!]: MUST Spec file is legible and written in American English.
Note: formatting is not consistent with Fedora template - the tag
values are not aligned vertically
[x]: MUST Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: SHOULD Reviewer should test that the package builds in mock.
[?]: SHOULD If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to
include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
--requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Package does not include license text files separate from
upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[?]: SHOULD Package should compile and build into binary rpms on all supported
architectures.
[-]: SHOULD %check is present and all tests pass.
[!]: SHOULD Packages should try to preserve timestamps of original installed
files.
Note: Manual in package has a newer timestamp (and different size) than
manual linked on webpage
> ls -l /usr/share/doc/objconv-2.14/
total 228
-rw-r--r--. 1 root root 231276 Jun 30 21:31 objconv-instructions.pdf
> wget -N http://www.agner.org/optimize/objconv-instructions.pdf
> ls -l objconv-instructions.pdf
-rw-r--r--. 1 mock mock 231271 Aug 3 2011 objconv-instructions.pdf
[x]: SHOULD Spec use %global instead of %define.
Issues:
[!]: MUST Spec file lacks Packager, Vendor, PreReq tags.
Note: Found : Vendor: Agner Fog
[!]: MUST Rpmlint output is silent.
rpmlint objconv-debuginfo-2.14-1.fc18.i686.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
rpmlint objconv-2.14-1.fc18.i686.rpm
objconv.i686: W: spelling-error Summary(en_US) disassembler -> disassemble,
disassembles, disassembled
objconv.i686: W: spelling-error %description -l en_US disassembler ->
disassemble, disassembles, disassembled
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
rpmlint objconv-2.14-1.fc18.src.rpm
objconv.src: W: spelling-error Summary(en_US) disassembler -> disassemble,
disassembles, disassembled
objconv.src: W: spelling-error %description -l en_US disassembler ->
disassemble, disassembles, disassembled
objconv.src:30: E: files-attr-not-set
objconv.src:31: E: files-attr-not-set
objconv.src: W: no-cleaning-of-buildroot %install
objconv.src: W: no-cleaning-of-buildroot %clean
objconv.src: W: no-buildroot-tag
objconv.src: W: no-%clean-section
1 packages and 0 specfiles checked; 2 errors, 6 warnings.
Generated by fedora-review 0.1.2
Summary of issues:
1. There must be no Vendor tag in spec
2. License inconsistency between package and upstream
3. rpmlint is not silent, but spelling-error should be allowed and others can
be ignored if not building for EPEL5
4. Installed manual has newer timestamp than original from upstream
5. Format of tags in spec file should be consistent with Fedora template
6. No man page for binary, as you acknowledged already.
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the package-review
mailing list