[Bug 841001] Review Request: libmatewnck - MATE Desktop Window Navigator Construction Kit libraries

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=841001

--- Comment #4 from raveit65 <chat-to-me at raveit.de> ---
a few suggestions :)

1. You have double entries of BuildRequires !

2. A empty row before %changelog would be nice.

3. We need only this as BuildRequires

BuildRequires:  glib2-devel
BuildRequires:  gtk2-devel
BuildRequires:  startup-notification-devel
BuildRequires:  libXres-devel
BuildRequires:  intltool
BuildRequires:  gobject-introspection-devel
BuildRequires:  mate-common
BuildRequires:  gtk-doc
BuildRequires:  cairo-gobject-devel

For XRes support in configure results we need libXres-devel, not libX11-devel

4. Reminder: no need of mate-common in Requires

5. startup-notification needs to be in Requires.

6. IHMO no need for gtk-doc in Requires, not shure
let's wait what Rex said.

In result of 4/5/6

Requires: startup-notification

7. Why configure flag --enable-gtk-doc-html ?
I use --enable-gtk-doc

8. I remove unecessary .la files with that line

find $RPM_BUILD_ROOT -name '*.la' -exec rm -f {} ';'

in %install section after make install.........

9. IHMO gobject-introspection files needs to be split in main and devel
Package, not shure.
%{_datadir}/gir-1.0/Matewnck-1.0.gir in -devel

%files -f %{name}.lang
%doc AUTHORS COPYING README NEWS
%{_bindir}/matewnck-urgency-monitor
%{_bindir}/matewnckprop
%{_libdir}/lib*.so.*
%{_libdir}/girepository-1.0/Matewnck-1.0.typelib

%files devel
%{_libdir}/lib*.so
%{_libdir}/pkgconfig
%{_includedir}/libmatewnck/libmatewnck
%{_datadir}/gir-1.0/Matewnck-1.0.gir
%doc %{_datadir}/gtk-doc

-- 
You are receiving this mail because:
You are on the CC list for the bug.