[Bug 807472] Review Request: libstoragemgmt - Library for storage array management

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 4 13:44:57 UTC 2012


https://bugzilla.redhat.com/show_bug.cgi?id=807472

--- Comment #8 from Tom "spot" Callaway <tcallawa at redhat.com> ---
Your SRPM does not appear to reflect the spec file changes, so I took your
spec.in file and tried to build it with the 0.0.7 tarball from sourceforge, but
it fails to compile.

In general, please remember that whenever you make changes to a spec file, you
should be incrementing Release and adding a changelog entry to describe the
changes made to the spec. (Release resets to 1 if Version goes up). This
workflow is why I generally do not recommend that projects autogenerate their
spec files.

Can you please upload a new working SRPM somewhere for me to review?

(Also, you shouldn't need to have that @VERSION@ string in the Source URL, just
use %{version} there.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the package-review mailing list