[Bug 825511] Review Request: python-django-south - Intelligent schema migrations for Django apps

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=825511

--- Comment #7 from Domingo Becker <domingobecker at gmail.com> ---
(In reply to comment #6)
> [!]: MUST Rpmlint output is silent.
> 
> rpmlint python-django-south-0.7.5-1.fc18.noarch.rpm
> 
> python-django-south.noarch: W: no-documentation
> python-django-south.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/south/tests/emptyapp/models.py
> python-django-south.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/south/tests/deps_a/models.py
> python-django-south.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/south/tests/circular_a/models.py
> python-django-south.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/south/tests/circular_b/models.py
> python-django-south.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/south/tests/deps_b/models.py
> python-django-south.noarch: E: zero-length
> /usr/lib/python2.7/site-packages/south/tests/deps_c/models.py
> 1 packages and 0 specfiles checked; 6 errors, 1 warnings.
> 
> 
> - You need to fix those errors.

I asked about this, and the answer was that these files are needed by
python-django even with zero-lenght.

> [!]: SHOULD If the source package does not include license text(s) as a
>      separate file from upstream, the packager SHOULD query upstream to
>      include it.
>
> - you should request upstream to include a license


I'll file a ticket upstream with this request.

> - you should include the README into %doc

Added.

> - you should list the files more specific in files-section.
> %files
> %doc README
> %{python_sitelib}/south
> %{python_sitelib}/South-%{version}-py?.?.egg-info
> 

Done this way.

> 
> - you really should(!) remove that bundled egg-info in prep-section. it gets
> rebuild during build section.
> 

Sorry, I don't understand.

Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-south.spec
SRPM URL:
http://beckerde.fedorapeople.org/transifex/python-django-south-0.7.5-2.fc18.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.