[Bug 827805] Review Request: python-ttystatus - Progress and status updates on terminals for Python

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=827805

Kevin Fenzi <kevin at scrye.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody at fedoraproject.org    |kevin at scrye.com
              Flags|                            |fedora-review+

--- Comment #4 from Kevin Fenzi <kevin at scrye.com> ---

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv3+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
7e7d507a77db43a285f1a1e17d09b4c3  python-ttystatus_0.18.orig.tar.gz
7e7d507a77db43a285f1a1e17d09b4c3  python-ttystatus_0.18.orig.tar.gz.orig
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Doc subpackage needed/used. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have subpackages require base package with fully versioned depend. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Issues: 

1. rpmlint says: 

python-ttystatus.noarch: W: spelling-error %description -l en_US initializer ->
initialize, initializes, initialized
python-ttystatus.src: W: spelling-error %description -l en_US initializer ->
initialize, initializes, initialized
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Can be ignored. 

I see no blockers here, so this package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.