[Bug 830992] Review Request: libseccomp - Enhanced seccomp library

bugzilla at redhat.com bugzilla at redhat.com
Tue Jun 12 15:31:36 UTC 2012


https://bugzilla.redhat.com/show_bug.cgi?id=830992

--- Comment #12 from Paul Moore <pmoore at redhat.com> ---
(In reply to comment #11)
> Off-head, I don't know if it's formally mandated. However without it, it's
> effectively impossible to review a package without major efforts, because
> the logs don't tell whether a package receives all CFLAGS/CPPFLAGS etc.
> correctly.

As mentioned in comment 10, we'll work on a verbose build for a future upstream
release but it would be very helpful to get this package added to Rawhide now
(as long as it meets all of the established requirements) so that we can make
progress in other areas which depend on this package simultaneously.

> Are you upstream? 

I've contributed the bulk of the code and cut the initial release.

> Openly said, I'd recommend upstream to switch to a more standardized
> build/make framework (be it autotools, cmake or what ever), because
> hand-written makefiles/makefile-fragments, like the ones being using by this
> package tend to become non-understood and unmaintainable in longer terms.

I understand the concern but I am not currently a fan of the build frameworks
that I've seen thus far and I'm unlikely to convert to them in the near term
unless their use is a requirement for acceptance into Fedora.  Looking towards
the future, I'll need to spend more time understanding the build frameworks
before I can give a definite "yes" or "no" regarding their inclusion in
libseccomp.

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the package-review mailing list