[Bug 825593] Review Request: bkhive - Dump the syskey bootkey from a Windows system hive

bugzilla at redhat.com bugzilla at redhat.com
Mon Jun 25 23:02:13 UTC 2012


https://bugzilla.redhat.com/show_bug.cgi?id=825593

--- Comment #2 from Michal Ambroz <rebus at seznam.cz> ---
Hello Fabian, 
thank you for taking the review.

1) [!]: MUST License field in the package spec file matches the actual license.
Thanks for spotting ... fixed to GPLv2+

2) [!]: MUST License field in the package spec file matches the actual license.
I do plan to support EPEL as well

3) [!]: MUST Rpmlint output is silent.
rpmlint contains only warnings because the terminology is not known to the
dictionay - bootkey, syskey, decrypt - all should be where they are

4) [!]: SHOULD SourceX / PatchY prefixed with %{name}.
Fixed - thank you

Spec URL: http://rebus.fedorapeople.org/SPECS/bkhive.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/bkhive-1.1.1-2.fc17.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.



More information about the package-review mailing list