[Bug 834069] Review Request: Clean - The Clean language compiler

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=834069

--- Comment #5 from Patrick Uiterwijk <puiterwijk at gmail.com> ---
Thanks for reviewing.
I have read your comments, and fixed as many as possible.

New SPEC: http://puiterwijk.fedorapeople.org/packages/Clean/Clean-2.spec
New SRPMS:
http://puiterwijk.fedorapeople.org/packages/Clean/Clean-2.4-2.fc17.src.rpm
New Koji link: http://koji.fedoraproject.org/koji/taskinfo?taskID=4203212



First, for the naming, I have decided to stay with Clean, because that is the
name upstream also uses (even in the middle of a sentence, they write it with
capital C: "Learn more about the Clean language by ...").
And according to the Naming Guidelines, you should keep the case as specified
by upstream.

The remove_tmp_files_linux script is only deleting a few object files which
were built in previous passes, it does not do anything considered dangerous.
I have modified it so that it will use rm -f, to evade the warnings.

I have versioned the build directory.

Compilation during installation has been fixed.
This was needed because clm compiles StdEnv for that specific machine.

I have set ExclusiveArch, since this version is only available on x86 and
x86_64.

The BuildRequire's have been removed.

I have changed CFLAGS= into CFLAGS+= and added the nessecary arguments to make.

rm -rf in %install has been removed.

Clean/doc now gets packaged into defaultdocdir/Clean

The attributes actually are needed, because the default of the Clean compiler
is 711.

The rpmlint messages are explained in the SPEC file now
# Known errors of RPMLINT:
# Name-repeated-in-summary: This is because the name of the language is the
same as that of the compiler
# Executable-stack: the Clean runtime system is built to use this, so this
cannot be changed without major overhauling of the Clean compiler itself
# Empty files (_startup.dcl, _startupTrace.dcl, _startupProfile.dcl,
_system.dcl, _library.dcl): these must be available while running the compiler
# Wrong-file-end-of-line-encoding: this has been requested upstream
# %ifarch-applied-patch: because the archives for 32-bit and 64-bit differ in
more then the bootstrapped files, this has to be done (some files have the same
name, but have different contents)

I have removed the debuginfo package option, because the Clean linker strips
all debug info, without any option to re-enable it.

I have added the %{?dist} tag.

I have used %{name} in the patchX names, for sourceX this is not possible,
because the archive names are with small letters.

-- 
You are receiving this mail because:
You are on the CC list for the bug.