[Bug 834239] Review Request: monobristol - frontend for britsol in mono

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=834239

--- Comment #9 from Orcan Ogetbil <oget.fedora at gmail.com> ---
Thanks, I made a full review on this. 

Before I get to that let me explain my experience. The monobristol gui shows up
for me with bunch of buttons. When I click on a button a black window pops up,
stays for a few seconds, then disappears. There I get error messages in the
terminal such as
   "Failed to open audio device default"
When I switch from ALSA to Jack, the Bristol synth GUI shows up, but I don't
get a sound. 

Here is the review:

! Please replace "bristol" with "Bristol" in Summary too.

* A package must own all directories that it creates or require another package
that does [1]. But %{_libdir}/%{name} remains unowned. So you will need to
replace
   %{_libdir}/%{name}/monoBristol.exe
by either
   %dir %{_libdir}/%{name}/
   %{_libdir}/%{name}/monoBristol.exe
or by simply
   %{_libdir}/%{name}/

* Similarly %{_datadir}/icons/hicolor/ remains unowned. But this directory
already depends on a standard package. So we will need to 
   Requires: hicolor-icon-theme

! Not really necessary in this case, but in my opinion, it would be nice to
explain what each patch does with a short comment.

* We got a new rpmlint
   monobristol.x86_64: W: percent-in-%post
Please replace the %>/dev/null with &>/dev/null

* The source code does not specify a license. There is a COPYING file for GPLv3
and the README file says the software is GPL. In particular [2] says
   A GPL or LGPL licensed package that lacks any statement of what version that
it's licensed under in the source code/program output/accompanying docs is
technically licensed under *any* version of the GPL or LGPL, not just the
version in whatever COPYING file they include. 
Therefore we shall set
   License: GPL+
Yet it is best to confirm this with upstream.

[1]
http://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
[2] http://fedoraproject.org/wiki/Licensing

-- 
You are receiving this mail because:
You are on the CC list for the bug.