[Bug 737293] Review Request: python-django - A high-level Python Web framework

bugzilla at redhat.com bugzilla at redhat.com
Mon Mar 19 07:44:00 UTC 2012


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737293

--- Comment #25 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> 2012-03-19 03:43:59 EDT ---
(In reply to comment #24)
> (In reply to comment #23)
> > Great! Maybe next time, it would be a good idea to provide a link to each patch
> > that was submitted upstream, so that you can track the upstream's progress on
> > this easily.
> Hmm, this is a work-around to get the tests running in koji builds. If you're
> building and/or testing Django in other environments, you also want those 5
> tests executed. I doubt, upstream will exclude those tests.

Yes, I didn't mean those. I mean the ones that were submitted upstream. And I
wanted to say, that for the patches that _get_ submitted upstream, you should
provide the links.


BTW, you can use %find_lang macro, like this:
%find_lang django
%find_lang djangojs # for the admin javascript locale files
And everything works just fine.

One more nit:
In %check section, you already are in %{_builddir}, so you just need to change
to %{pkgname}-%{version}, But that's really just a minor simplification :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list