[Bug 805037] Review Request: commons-compiler - Interfaces for an embedded Java compiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=805037

Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #6 from Jerry James <loganjerry at gmail.com> 2012-03-30 12:58:12 EDT ---
(In reply to comment #5)
> Note that you can't download the POM from repo1.maven.org with wget (permission
> denied), but you can download it through a web browser.

This works: "wget -U firefox
http://repo1.maven.org/maven2/org/codehaus/janino/commons-compiler/2.6.1/commons-compiler-2.6.1.pom".

There is only one remaining issue, which I forgot to highlight by copying to
the "Issues" section at the bottom.  Sorry about that; this is my first time
using fedora-review, after all.  Anyway, the last issue is this:

> [!]: SHOULD Packages should try to preserve timestamps of original installed
>      files.  Add "-p" to "cp %{SOURCE1} ./pom.xml".

With the new source numbering, -p should be added to the cp commands for both
SOURCE1 and SOURCE2.  I trust you to do that before importing this package.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.