[Bug 815511] Review Request: python-django-lint - Analyzes Django code looking for bugs and signs of poor quality

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=815511

--- Comment #4 from Matthias Runge <mrunge at matthias-runge.de> 2012-05-01 15:54:53 EDT ---
Thanks to both of you for your comments.

- clean: yepp, agreed, dropping that
- non exec-script: not needed, dropping /usr/bin/env
- rebasing to github-checkout

Updated 
SPEC: http://www.matthias-runge.de/fedora/python-django-lint.spec
SRPM:
http://www.matthias-runge.de/fedora/python-django-lint-0.13-13.20120501git194ce26.fc17.src.rpm

[mrunge at sofja SPECS]$ rpmlint
../SRPMS/python-django-lint-0.13-13.20120501git194ce26.fc17.src.rpm
../RPMS/noarch/python-django-lint-0.13-13.20120501git194ce26.fc17.noarch.rpm
./python-django-lint.spec 
python-django-lint.src: W: spelling-error %description -l en_US py -> pt, p, y
python-django-lint.noarch: W: spelling-error %description -l en_US py -> pt, p,
y
2 packages and 1 specfiles checked; 0 errors, 2 warnings.





[mrunge at sofja SPECS]$ diff -u python-django-lint.spec.2 python-django-lint.spec
--- python-django-lint.spec.2 2012-04-23 20:27:16.000000000 +0200
+++ python-django-lint.spec 2012-05-01 21:48:14.226774782 +0200
@@ -1,21 +1,18 @@
 %global pkgname django-lint
 %global obs_ver 0.13-11
+%global commit 194ce26

 Name:           python-django-lint
 Version:        0.13
-Release:        12%{?dist}
+Release:        13.20120501git%{commit}%{?dist}
 Summary:        Analyzes Django code looking for bugs and signs of poor
quality

 Group:          Development/Debuggers
 License:        GPLv3+
 URL:            https://github.com/lamby/django-lint
-# upstream author is debian maintainer, took release from debian page
-Source0:       
http://ftp.de.debian.org/debian/pool/main/p/%{name}/%{name}_%{version}.orig.tar.gz
+Source0:       
https://github.com/lamby/django-lint/tarball/%{commit}/lamby-django-lint-%{commit}.tar.gz
 BuildArch:      noarch

-# fix from upstream for iterable-issue
-# https://github.com/lamby/django-lint/pull/6
-Patch0:         django-lint-type-error-iterable.patch

 BuildRequires:  python2-devel
 Requires:       python-django
@@ -38,24 +35,21 @@


 %prep
-%setup -q -n %{pkgname}
-%patch0 -p2
+%setup -q -n lamby-%{pkgname}-%{commit}
+# remove unneeded /usr/bin/env-call
+sed -i 's|^#!/usr/bin/env.*||' DjangoLint/script.py

 %build
 %{__python} setup.py build


 %install
-rm -rf %{buildroot}
 %{__python} setup.py install -O1 --skip-build --root %{buildroot}

 %{__mkdir} -pm 755 %{buildroot}%{_mandir}/man1
 %{__install} -pm 644 django-lint.1 %{buildroot}%{_mandir}/man1/


-%clean
-rm -rf %{buildroot}
-

 %files
 %doc  README.rst COPYING
@@ -66,6 +60,10 @@


 %changelog
+* Mon Apr 30 2012 Matthias Runge <mrunge at matthias-runge.de> -
0.13-13.20120501git194ce26
+- minor spec cleanup
+- rebase to latest github snapshot
+
 * Mon Apr 23 2012 Matthias Runge <mrunge at matthias-runge.de> - 0.13-12
 - package rename to python-django-lint

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.