[Bug 672205] Review Request: pynag - Python Nagios plugin and configuration environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=672205

Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |
               Flag|fedora-review?              |fedora-review+

--- Comment #16 from Jason Tibbitts <tibbs at math.uh.edu> 2012-05-09 14:45:58 EDT ---
OK, the new package looks good.

APPROVED

One detail I forgot to mention previously relates to this line in %install:
  test "x$RPM_BUILD_ROOT" != "x" && rm -rf $RPM_BUILD_ROOT
It's really not necessary to do that and hasn't been for a really long time
now.  More modern releases don't need any of that, but since you want to build
on RHEL5, you just need:
  rm -rf $RPM_BUILD_ROOT

Anyway, this isn't particularly problematic; it's just a cleanliness issue. 
I've already sponsored you into the packager group, so once those new
permissions propagate through the system you'll be able to make your SCM
request.

As your sponsor I'm here to help you through the rest of the process, so please
don't hesitate to ask any questions you may have.  It is probably easiest to
reach me via IRC on #fedora-devel; I see you've been there recently and any
questions you ask can potentially be answered by anyone in the channel if I
don't happen to be around.  Or you can contact me via email.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.