[Bug 820542] Review Request: libguac - The common library used by all C components of Guacamole

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=820542

--- Comment #9 from Ralf Corsepius <rc040203 at freenet.de> 2012-05-12 01:07:23 EDT ---
(In reply to comment #7)
> A few pre-review remarks:
> 
> * The first line in %build, "export CFLAGS="$RPM_OPT_FLAGS", is unnecessary.
Agreed. It also doesn't help wrt. the "-Werror -pedantic" issue, because this
package has "-Werror -Wall -pedantic" hard-coded into its Makefile.am.

The ultimate fix would be upstream to remove it there.

There'd be other ways to work around this locally, but for now, there is no
need for any action for Fedora.

> * The configure run includes this line:
> 
>   checking for clock_gettime... no

An easier way is to append LIBS to %configure:
%configure --disable-static LIBS="-lrt"
instead of modifying configure.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.