[Bug 739015] Review Request: erlang-riak_sysmon - Rate-limiting system_monitor event handler for Riak

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=739015

--- Comment #4 from Peter Lemenkov <lemenkov at gmail.com> ---
First of all thanks for picking this up, Michael!

(In reply to comment #2)
> Hi, 
> 
> - why is debug package disabled ?
> ( I assume that's because that's erlang, but in the absence of mention in
> the draft erlang packaging policy, I prefer to ask )

Yep, that's one of the currrent Erlang shortcomings. Every module must be
installed into %{_libdir}/erlang/lib (actually "should" not "must", but
otherwise it requires some manual intervention and several changes into
application's sources). And since %{_libdir} is arch-dependent the entire
package becomes arch-dependent as well. To suppress useless debuginfo
generation we're using "%global debug_package %{nil}" directive at the top of
the packages like this.

This definitely looks ugly, and I plan to fix it in the future. Also I
apologise for absence of Erlang Packaging Policy - we'll probably come up with
something worth to reading before F-19.

> - lots of stuff are not needed anymore for newer Fedora :
> 
> %clean
> rm -rf $RPM_BUILD_ROOT
> 
> rm -Rf in the beginning of %install
> 
> %defattr(-,root,root,-)
> 
> BuildRoot:	%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

Actually my primary goal is EL6 (and I'm considering EL5 as well) so I have to
keep vintage stuff.

> - could you explain how the test fail in koji ( at least, with a comment ? )

Yep. that was my fault - I didn't realise that I need to start epmd daemon
before running tests. Erlang Port Monitor Daemon is a generic service which
allows different local and remote Erlang nodes to exchange data. Since this
package is exactly about monitoring of data exchange channels then it requires
epmd to run. Sorry for that - I provided fixed version:

http://peter.fedorapeople.org/erlang-riak_sysmon.spec
http://peter.fedorapeople.org/erlang-riak_sysmon-1.1.2-2.fc18.src.rpm

Koji scratchbuild for F-18:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4093357

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.fedoraproject.org/pipermail/package-review/attachments/20120522/f7b76ebf/attachment.html>